update easyconfigs to use SYSTEM template constant instead of True in dependencies#16386
Merged
Merged
Conversation
…asyconfigs into switch-true-to-system
casparvl
approved these changes
Oct 11, 2022
casparvl
left a comment
casparvl
left a comment
Contributor
There was a problem hiding this comment.
It's a ton of EasyConfigs, but I've scrolled through the changes and haven't spotted anything unintended. It's an approval from me, but since this affects so many EasyConfigs, I'll ask at least one other maintainer to also look at this :)
boegel
changed the title
SYSTEM instead of True in dependenciesSYSTEM template instead of True in dependencies
boegel
changed the title
SYSTEM template instead of True in dependenciesSYSTEM template constant instead of True in dependencies
Member
|
Test report by @boegel |
Member
|
Going in, thanks @jfgrimm! |
jfgrimm
added a commit
to jfgrimm/easybuild-easyconfigs
that referenced
this pull request
Oct 12, 2022
This was referenced Oct 12, 2022
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #16330 and #16384
for reference, the substitution pattern used:
sed -i "s|', True)|', SYSTEM)|g"haven't spotted any cases where this caused an issue